fix: look at the underlying of a TermRef for a getter #24565
Merged
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
added
the
backport:nominated
hamzaremmal
commented
Nov 27, 2025
| jsig(erasedUnderlying, toplevel = toplevel, unboxedVCs = unboxedVCs) | ||
| else typeParamSig(ref.paramName.lastPart) | ||
|
|
||
| case ref: TermRef if ref.symbol.isGetter => |
Member
Author
There was a problem hiding this comment.
Equivalent in TypeErasure:
scala3/compiler/src/dotty/tools/dotc/core/TypeErasure.scala
Lines 804 to 806 in fe49539
hamzaremmal
commented
Nov 27, 2025
| public final void java.lang.Object.wait(long,int) throws java.lang.InterruptedException | ||
| public final void java.lang.Object.wait() throws java.lang.InterruptedException | ||
| public final native void java.lang.Object.wait(long) throws java.lang.InterruptedException | ||
| public int Foo.x() |
Member
Author
There was a problem hiding this comment.
Before this fix, we would have gotten:
public scala.Function0<java.lang.Object> Foo.x()
sjrd
approved these changes
Dec 1, 2025
WojciechMazur
added
backport:accepted
WojciechMazur
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the type of a
valis aTermRef, generating the generic signature based on the underlying type will produce the typescala.Function0<underlying>. The reason behind this is that during thegettersphase, the same symbol will now refer to the getter where the type will be=> <underlying>. Since theTermReforiginally intended to capture the underlying type of aval, we recover that information by directly checking the resultType of the getter.Closes #24553